language agnostic - How to recognize that short code blocks can be refactored into something cleaner? -

-

I have a little code that I wrote a few weeks ago (the purpose of the code is not very important as its structure) : 

  if (_image.Empty) {// use the real image size if they have not specified a custom size if (_glyphSize.Width> 0) imageSize.Width = _glyphSize Width // override other image With = _image.GetWidth; If (_glyphSize.Height> gt; 0) then image size. Hi = _glyphSize.Height and Choiceist Heights = _image.GetHeight} else {// No image, but they can still override it with a custom shape if _glyphSize.Width> = 0; If (_glyphSize.Height> gt; 0) imageSize.Height = _glyphSize.Height and Choiceist Height: = 0; }

I was going into it tonight, and when I was cleaning it, I realized the clean version should be more concise: 

  // Understand the width of the final image if (_glyphSize.Width> 0) imageSize.Width = _glyphSize.Width else if (not _glyph.Empty) imageSize.Width = _glyph.GetWidth else imageSize.Width = 0; // See the final image height, if (_glyphSize.Height> gt; 0) imageSize.Height = _glyphSize.Height else if (not _glyph.Empty) imageSize.Height = _glyph.GetHeight and Choiceist. Heights = 0;  Note:  I have trimmed the code for unnecessary logical flow, and read the source language.  
 Finally, I took the nestined  if , and reversed them, doing this was allowed to do this shoring. My question is how can I recognize it in the future? 
 
 What are the signs of narrative-narrative, which I have just written some code that can be re-applied at least? 
 
 
 A few other weeks ago, I had a similar permission check like this: The user can do one thing: 
 
     
  •  If they have permission they can do it 
    •  
  •  If they do not have permission, but override is in effect 
    •  
 
 which I initially coded: 
 
  if ((HasPermission | | (Promotion and override active) {... work done}  
 
 The logical conditions on that  clause were verbatim I Tried to get back to my boolean algebra course to explain how to simplify it. Finally I can do this, so I stopped pulling the truth table:  
  Permission Override results 0 0 0 1 1 1 0 1 1 1 1  
 
 When I see it is a  or  operation then my  if  statement Has become: 
 
  if (smoothened or overridden enneed) {...}  
 
 which is clear and simple. And now I am thinking How can I not start? 
 
 
 I have been brought back to my SO question: should I show the fairytale signal in / me to make sure that some blocks of code Need some TLC?

Here are some guidelines to complete the code above my head

  • long Loops up to time
  • This is a good book for this type of thing.

    1. Nested if-
    2. For some reasons if you are copying and pasting a line of code frequently

    I discrete mathematics got an effect of how I statement if statement has been made now. Generally, I think I am writing two statements in two blocks, then I will do some mental 'factoring'.


    • Comments

    Post a Comment

    Popular posts from this blog

    php - multilevel menu with multilevel array -

    -
    Just ask someone to solve this problem? I want to create a multilevel menu I can not find the right solution generated with multilevel array, it always gets an array_push error My study came from the original idea But still my Can not match the need. This is my MySQL [code] ----- --------------------- --------------- | ID | PARENT_ID | Name | Link | Seq | 1 | 0 | Dashboad | Dashboard / | 1 | 2 | 0 | Menu 1 | Menu 1 / | 2 | 3 | 0 | Menu 2 | Menu 2 / | 3 | 4 | 0 | Menu 3 | Menu 3 / | 4 | 5 | 2 | Joint Add / | 1 | 6 | 3 | Joint Add / | 1 | 7 | 2 | Edit | Edit / | 2 | 8 | 4 | Joint Add / | 1 ------------------------------------------ [/ Code] I want to do something like this in my array array ('dashboard' = & gt; array ('id' = & gt; '' 'Dame' = & gt; 'Dashboard', 'Title' = & gt; 'Dashboard', 'MatchMin' = & gt; Base_URL (). 'Dashboard /', 'Active' => = & Gt; NULL), ...
    Read more

    c# - TypeConverter in propertygrid only converts from string, not to -

    -
    When the property grid is reached, only the conversion mechanism (often called) is called "Foo!" Returns the property string in the grid when I click to edit I get an exception Type.oo. Object type can not be changed to type. (Not properly translated,) What is a clue from the convert format, why not? And the error indicates that it is trying to convert to a string, not from. I think that when I want to edit this object, it will have to be converted from foo to string, and when the editing ends. Public class FooTypeConverter: StringConverter {public override object ConvertFrom (ITypeDescriptorContext Reference, CultureInfo Culture, Object Value) {New Foo (string) value); } Convert the public override object (Type the ITE DiskText Contact Reference, CultureInfo Culture, Object Value, Type Type) {Return "Foo!"; } Public override bool CanConvertFrom (ITypeDescriptorContext reference, type source type) {back true; } Public Override Bull CanConvertTo (ITypeDescrip...
    Read more

    jQuery UI: Datepicker month format -

    -
    I am trying to change the format of the month that shows in the popup (not in the date that the picker actually I do not have any choice anywhere to do this, do I like to use a sub-string () or something else? What I normally display is Trying to change: Class = "ui-datepicker-title"> January & lt; / span & gt; ... & lt; / div & gt; Div>
    Read more